gjacoby126 commented on pull request #913: URL: https://github.com/apache/phoenix/pull/913#issuecomment-736887345
In this latest revision: 1. I added a new boolean flag, CHANGE_DETECTION_ENABLED to System.Catalog which is configured via property on table or view creation. It can be changed via ALTER. Adding it to an index will fail. Only tables and views with this flag set to true (it defaults false) will have their changes annotated into the WAL. Future JIRAs (such as PHOENIX-6227, and the main CDC code which will go in phoenix-connectors) will also use this flag. 2. Indexes are no longer annotated. 3. Shifted WALAnnotationIT to use the SchemaBuilder API introduced with Phoenix TTL I believe the one remaining request left to do is @kadirozde 's suggestion to do a perf test. I will do this over the next couple of days. @ChinmaySKulkarni , @kadirozde , fyi. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
