[
https://issues.apache.org/jira/browse/PHOENIX-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242244#comment-17242244
]
ASF GitHub Bot commented on PHOENIX-6240:
-----------------------------------------
stoty commented on pull request #41:
URL: https://github.com/apache/phoenix-connectors/pull/41#issuecomment-737149581
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 8m 43s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 8m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 13m 0s | master passed |
| +1 :green_heart: | compile | 4m 59s | master passed |
| +1 :green_heart: | checkstyle | 1m 50s | master passed |
| +1 :green_heart: | javadoc | 1m 36s | master passed |
| +0 :ok: | spotbugs | 1m 42s | phoenix-hive-base in master has 46
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 47s | phoenix-hive-base/phoenix4-hive in
master has 46 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 56s | phoenix-hive-base/phoenix5-hive in
master has 45 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 1m 11s | phoenix-pig-base in master has 18
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 38s | phoenix-spark-base in master has 40
extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 34s | the patch passed |
| +1 :green_heart: | compile | 4m 19s | the patch passed |
| +1 :green_heart: | javac | 4m 19s | the patch passed |
| -1 :x: | checkstyle | 0m 9s | phoenix-hive-base/phoenix4-hive: The
patch generated 10 new + 72 unchanged - 10 fixed = 82 total (was 82) |
| -1 :x: | checkstyle | 0m 11s | phoenix-hive-base/phoenix5-hive: The
patch generated 19 new + 74 unchanged - 20 fixed = 93 total (was 94) |
| -1 :x: | checkstyle | 0m 38s | phoenix-hive-base: The patch generated
71 new + 1629 unchanged - 61 fixed = 1700 total (was 1690) |
| -1 :x: | checkstyle | 0m 15s | phoenix-pig-base: The patch generated
9 new + 320 unchanged - 8 fixed = 329 total (was 328) |
| -1 :x: | checkstyle | 0m 11s | phoenix-spark-base: The patch
generated 6 new + 55 unchanged - 6 fixed = 61 total (was 61) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 1m 25s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 38s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 14m 45s | phoenix4-hive in the patch passed.
|
| +1 :green_heart: | unit | 11m 53s | phoenix5-hive in the patch passed.
|
| +1 :green_heart: | unit | 25m 39s | phoenix-hive-base in the patch
passed. |
| +1 :green_heart: | unit | 5m 24s | phoenix-pig-base in the patch
passed. |
| +1 :green_heart: | unit | 43m 33s | phoenix-spark-base in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 43s | The patch does not generate
ASF License warnings. |
| | | 172m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-41/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/41 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile xml |
| uname | Linux e672ebd00588 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 885e2b8 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-41/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-hive-base_phoenix4-hive.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-41/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-hive-base_phoenix5-hive.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-41/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-hive-base.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-41/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pig-base.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-41/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-spark-base.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-41/1/testReport/
|
| Max. process+thread count | 1720 (vs. ulimit of 30000) |
| modules | C: phoenix-hive-base/phoenix4-hive
phoenix-hive-base/phoenix5-hive phoenix-hive-base phoenix-pig-base
phoenix-spark-base U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-41/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Standardize connectors logging on SLF4j
> ----------------------------------------
>
> Key: PHOENIX-6240
> URL: https://issues.apache.org/jira/browse/PHOENIX-6240
> Project: Phoenix
> Issue Type: Improvement
> Components: connectors
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> We have already standardized on SLF4j in the other projects, finish this in
> connectors.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
