[
https://issues.apache.org/jira/browse/PHOENIX-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242920#comment-17242920
]
ASF GitHub Bot commented on PHOENIX-6240:
-----------------------------------------
stoty commented on pull request #41:
URL: https://github.com/apache/phoenix-connectors/pull/41#issuecomment-737673575
> Only risk I can think of is that, if we are copying code directly from
Hive (so we can modify), this change will make that harder. However, I think
making this change and taking on that burden later is just fine.
True. However the connector used to use commons-logging, while AFAICT Hive
mostly uses SLF4j with log4j2 as backend, so it was probably modelled after
the old Phoenix logging.
> We should also think about adding in some enforcer logic to prevent logger
imports from log4j or commons-logging in the future.
maven-dependency-check takes care of that in most cases, as long as we don't
explicitly depend on other loggers for some reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Standardize connectors logging on SLF4j
> ----------------------------------------
>
> Key: PHOENIX-6240
> URL: https://issues.apache.org/jira/browse/PHOENIX-6240
> Project: Phoenix
> Issue Type: Improvement
> Components: connectors
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> We have already standardized on SLF4j in the other projects, finish this in
> connectors.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
