stoty commented on a change in pull request #1035:
URL: https://github.com/apache/phoenix/pull/1035#discussion_r548977484
##########
File path: pom.xml
##########
@@ -1249,6 +1270,11 @@
<artifactId>protobuf-java</artifactId>
<version>${protobuf-java.version}</version>
</dependency>
+ <dependency>
Review comment:
I this dependency necessary ?
##########
File path: phoenix-core/pom.xml
##########
@@ -194,6 +194,24 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>compile-protoc</id>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>compile</goal>
+ </goals>
+ <configuration>
+ <protoSourceRoot>${basedir}/src/main/protobuf/</protoSourceRoot>
Review comment:
These are redundant with the parent dependencyManagement section.
Setting them here, or in the dependencyManagement section should be enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
