stoty commented on a change in pull request #1035:
URL: https://github.com/apache/phoenix/pull/1035#discussion_r548978846
##########
File path: phoenix-core/pom.xml
##########
@@ -194,6 +194,24 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>compile-protoc</id>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>compile</goal>
+ </goals>
+ <configuration>
+ <protoSourceRoot>${basedir}/src/main/protobuf/</protoSourceRoot>
Review comment:
Sorry, I only meant the configuration entries.
Declaring the plugin and the version in the top dependencyManagement section
is good practice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
