[
https://issues.apache.org/jira/browse/PHOENIX-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255011#comment-17255011
]
ASF GitHub Bot commented on PHOENIX-6282:
-----------------------------------------
stoty commented on a change in pull request #1035:
URL: https://github.com/apache/phoenix/pull/1035#discussion_r548977484
##########
File path: pom.xml
##########
@@ -1249,6 +1270,11 @@
<artifactId>protobuf-java</artifactId>
<version>${protobuf-java.version}</version>
</dependency>
+ <dependency>
Review comment:
I this dependency necessary ?
##########
File path: phoenix-core/pom.xml
##########
@@ -194,6 +194,24 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.xolstice.maven.plugins</groupId>
+ <artifactId>protobuf-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>compile-protoc</id>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>compile</goal>
+ </goals>
+ <configuration>
+ <protoSourceRoot>${basedir}/src/main/protobuf/</protoSourceRoot>
Review comment:
These are redundant with the parent dependencyManagement section.
Setting them here, or in the dependencyManagement section should be enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Generate PB files inline with build and remove checked in files
> ---------------------------------------------------------------
>
> Key: PHOENIX-6282
> URL: https://issues.apache.org/jira/browse/PHOENIX-6282
> Project: Phoenix
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
>
> We can use a new PB maven plugin to generate PB files with build rather than
> checking in generated PB files (~2 MB as of now) in source code. The plugin
> also provides an optimization for protoc invocation. With checkStaleness
> property, protoc will not be invoked if no .proto file is changed. Only
> separate build will invoke protoc and generate PB files inline.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
