[
https://issues.apache.org/jira/browse/PHOENIX-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255025#comment-17255025
]
ASF GitHub Bot commented on PHOENIX-6282:
-----------------------------------------
stoty commented on pull request #1035:
URL: https://github.com/apache/phoenix/pull/1035#issuecomment-751353141
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 52s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 5s | master passed |
| +1 :green_heart: | compile | 1m 17s | master passed |
| +1 :green_heart: | checkstyle | 8m 47s | master passed |
| +1 :green_heart: | javadoc | 1m 54s | master passed |
| +0 :ok: | spotbugs | 2m 55s | phoenix-core in master has 973 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 51s | root in master has 1022 extant spotbugs
warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 27s | the patch passed |
| +1 :green_heart: | compile | 1m 18s | the patch passed |
| +1 :green_heart: | cc | 1m 18s | the patch passed |
| +1 :green_heart: | javac | 1m 18s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 31s | root: The patch generated 0
new + 0 unchanged - 19283 fixed = 0 total (was 19283) |
| -1 :x: | prototool | 0m 3s | The patch generated 30 new + 6
unchanged - 0 fixed = 36 total (was 6) |
| +1 :green_heart: | shellcheck | 0m 1s | The patch generated 0 new +
0 unchanged - 9 fixed = 0 total (was 9) |
| +1 :green_heart: | shelldocs | 0m 0s | There were no new shelldocs
issues. |
| -1 :x: | whitespace | 0m 0s | The patch has 9 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| -1 :x: | whitespace | 0m 0s | The patch 4 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 1m 55s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 7s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 108m 7s | root in the patch failed. |
| -1 :x: | asflicense | 0m 57s | The patch generated 1 ASF License
warnings. |
| | | 165m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1035/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1035 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
spotbugs hbaseanti checkstyle cc prototool shellcheck shelldocs |
| uname | Linux 422996c090bb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 2b68e84 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| prototool |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1035/3/artifact/yetus-general-check/output/diff-patch-prototool.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1035/3/artifact/yetus-general-check/output/whitespace-eol.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1035/3/artifact/yetus-general-check/output/whitespace-tabs.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1035/3/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1035/3/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1035/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 6598 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1035/3/console
|
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 spotbugs=4.1.3
prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Generate PB files inline with build and remove checked in files
> ---------------------------------------------------------------
>
> Key: PHOENIX-6282
> URL: https://issues.apache.org/jira/browse/PHOENIX-6282
> Project: Phoenix
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
>
> We can use a new PB maven plugin to generate PB files with build rather than
> checking in generated PB files (~2 MB as of now) in source code. The plugin
> also provides an optimization for protoc invocation. With checkStaleness
> property, protoc will not be invoked if no .proto file is changed. Only
> separate build will invoke protoc and generate PB files inline.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
