wangchao316 commented on pull request #1039: URL: https://github.com/apache/phoenix/pull/1039#issuecomment-752346084
> Left few comments. > HBASE-24850 is not yet released, fixed version: 2.5.0, 2.4.1, 2.3.4 (in progress releases) and HBASE-24754 is still open. > However, as long as this patch stays with Phoenix 5.x, we are good since `KVComparator` is anyways deprecated. +1(non-binding) once comments are addressed. Thanks @wangchao316 thanks @virajjasani . change KVComparator reason have two : 1.KVComparator have deprecated, and hbase 2.x do not recommend using. 2.once hbase-24850 fixed 2.x version, phoenix base-function is impect. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
