wangchao316 commented on a change in pull request #1039:
URL: https://github.com/apache/phoenix/pull/1039#discussion_r549988834
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
##########
@@ -430,12 +429,12 @@ public Integer call() throws SQLException {
}
//Force update cache and retry if meta not found
error occurs
catch (MetaDataEntityNotFoundException e) {
- if(doRetryOnMetaNotFoundError &&
e.getTableName()!=null){
- if(LOGGER.isDebugEnabled())
- LOGGER.debug("Reloading table "+
e.getTableName()
- +" data from server");
- if(new
MetaDataClient(connection).updateCache(connection.getTenantId(),
- e.getSchemaName(), e.getTableName(),
true).wasUpdated()){
+ if (doRetryOnMetaNotFoundError &&
e.getTableName() != null) {
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Reloading table " +
e.getTableName() + " data from server");
Review comment:
> same here
phoenix code have more this ways that not placeholder in log. I will solved
this in another issues.
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -2461,11 +2464,11 @@ public Object run() throws Exception {
try (PhoenixConnection connection =
QueryUtil.getConnectionOnServer(env.getConfiguration())
.unwrap(PhoenixConnection.class))
{
- try{
+ try {
MetaDataUtil.deleteFromStatsTable(connection,
deletedTable,
physicalTableNames, sharedTableStates);
- LOGGER.info("Table stats deleted successfully.
"+
-
deletedTable.getPhysicalName().getString());
+ LOGGER.info("Table stats deleted successfully.
"
+ +
deletedTable.getPhysicalName().getString());
Review comment:
phoenix code have more this ways that not placeholder in log. I will
solved this in another issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
