[
https://issues.apache.org/jira/browse/PHOENIX-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258303#comment-17258303
]
ASF GitHub Bot commented on PHOENIX-6295:
-----------------------------------------
stoty commented on pull request #1054:
URL: https://github.com/apache/phoenix/pull/1054#issuecomment-754068664
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 11s | 4.x passed |
| +1 :green_heart: | compile | 1m 4s | 4.x passed |
| +1 :green_heart: | checkstyle | 2m 21s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 17s | phoenix-core in 4.x has 962 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 3s | the patch passed |
| +1 :green_heart: | compile | 1m 4s | the patch passed |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| -1 :x: | checkstyle | 2m 20s | phoenix-core: The patch generated 60
new + 6925 unchanged - 64 fixed = 6985 total (was 6989) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| -1 :x: | spotbugs | 3m 32s | phoenix-core generated 1 new + 947
unchanged - 15 fixed = 948 total (was 962) |
||| _ Other Tests _ |
| -1 :x: | unit | 190m 30s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate
ASF License warnings. |
| | | 231m 58s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.hbase.index.covered.update.IndexUpdateManager$MutationComparator
implements Comparator but not Serializable At
IndexUpdateManager.java:Serializable At IndexUpdateManager.java:[lines 47-94] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1054 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux e0ea573d2332 4.15.0-101-generic #102-Ubuntu SMP Mon May 11
10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 5ad54f9 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/testReport/
|
| Max. process+thread count | 5696 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1054/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix non-static inner classes for better memory management
> ---------------------------------------------------------
>
> Key: PHOENIX-6295
> URL: https://issues.apache.org/jira/browse/PHOENIX-6295
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> If an inner class does not need to reference its enclosing instance, it can
> be static. This prevents a common cause of memory leaks and uses less memory
> per instance of the class (enclosing).
> Came across StatsDeleteHandler as a non static inner class defined in
> MetaDataEndpointImpl without holding any implicit reference to
> MetaDataEndpointImpl. Taking this opportunity to find other non-static inner
> classes that are not holding implicit reference to their respective enclosing
> instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
