[
https://issues.apache.org/jira/browse/PHOENIX-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258696#comment-17258696
]
ASF GitHub Bot commented on PHOENIX-6295:
-----------------------------------------
stoty commented on pull request #1053:
URL: https://github.com/apache/phoenix/pull/1053#issuecomment-754436022
As we don't seem to use the java serialization framework anywhere, and your
patch doesn't change anything WRT the java serialization situation, It doesn't
really matter.
You may as well make the class Serializable, as it has no state, and it
wouldn't make any difference to us, and silence spotbugs, but it's good either
way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix non-static inner classes for better memory management
> ---------------------------------------------------------
>
> Key: PHOENIX-6295
> URL: https://issues.apache.org/jira/browse/PHOENIX-6295
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> If an inner class does not need to reference its enclosing instance, it can
> be static. This prevents a common cause of memory leaks and uses less memory
> per instance of the class (enclosing).
> Came across StatsDeleteHandler as a non static inner class defined in
> MetaDataEndpointImpl without holding any implicit reference to
> MetaDataEndpointImpl. Taking this opportunity to find other non-static inner
> classes that are not holding implicit reference to their respective enclosing
> instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
