stoty commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r554105323
##########
File path: pom.xml
##########
@@ -343,18 +343,6 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
Review comment:
Looking at again, this still might have effect on Pherf.
It probably should be purged, but not today.
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Those are only used when running the tests on a real cluster, which
feature is broken in many ways.
Almost no-one uses it, and it doesn't affect the maven test suite.
And by the pherf tests, which really should be fixed :)
It doesn't hurt to synchronize it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
