virajjasani commented on a change in pull request #1078:
URL: https://github.com/apache/phoenix/pull/1078#discussion_r553889088
##########
File path: pom.xml
##########
@@ -343,18 +343,6 @@
</goals>
</execution>
<execution>
- <id>HBaseManagedTimeTests</id>
Review comment:
Oh this is not even being used
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Looks like this is recent addition right? We could include
`deletePriorMetaData()` too?
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -708,7 +705,7 @@ protected static String getOrganizationId() {
private static long timestamp;
- public static long nextTimestamp() {
+ public static synchronized long nextTimestamp() {
Review comment:
Or maybe just synchronizing `deletePriorMetaData()` could be enough as
it would cover `deletePriorTables()`, `nextTimestamp()` and
`deletePriorSchemas()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
