[
https://issues.apache.org/jira/browse/PHOENIX-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262453#comment-17262453
]
ASF GitHub Bot commented on PHOENIX-6309:
-----------------------------------------
virajjasani commented on pull request #1082:
URL: https://github.com/apache/phoenix/pull/1082#issuecomment-757674069
Attaching sample build failure:
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports
failed with message:
Banned imports detected in TEST code:
Reason: Use commons lang 3
in file: org/apache/phoenix/end2end/AlterTableWithViewsIT.java
org.apache.commons.lang.StringUtils (Line: 41, Matched by:
org.apache.commons.lang.**)
Analysis took 0 seconds
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Phoenix 5.1.0-SNAPSHOT ...................... SUCCESS [ 1.701
s]
[INFO] Phoenix Hbase 2.4.0 compatibility .................. SUCCESS [ 3.718
s]
[INFO] Phoenix Hbase 2.3.0 compatibility .................. SUCCESS [ 0.946
s]
[INFO] Phoenix Hbase 2.2.1 compatibility .................. SUCCESS [ 0.893
s]
[INFO] Phoenix Hbase 2.1.6 compatibility .................. SUCCESS [ 0.620
s]
[INFO] Phoenix Core ....................................... FAILURE [ 3.595
s]
[INFO] Phoenix - Pherf .................................... SKIPPED
[INFO] Phoenix Client Parent .............................. SKIPPED
[INFO] Phoenix Client ..................................... SKIPPED
[INFO] Phoenix Server ..................................... SKIPPED
[INFO] Phoenix - Tracing Web Application .................. SKIPPED
[INFO] Phoenix Assembly ................................... SKIPPED
[INFO] phoenix-tools ...................................... SKIPPED
[INFO] Phoenix Client Embedded 5.1.0-SNAPSHOT ............. SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 12.127 s
[INFO] Finished at: 2021-01-11T12:57:06+05:30
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce
(banned-illegal-imports) on project phoenix-core: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. ->
[Help 1]
[ERROR]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use maven enforcer to ban imports
> ---------------------------------
>
> Key: PHOENIX-6309
> URL: https://issues.apache.org/jira/browse/PHOENIX-6309
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> We are already using mvn enforcer plugin for hbase version evaluations. We
> can extend it's usage to restrict-imports-enforcer-rule enforcer and ban
> imports from illegal packages (as per our project guidelines)
> e.g restrict usage of org.apache.commons.logging, com.google.common (in the
> presence of phoenix-thirdparty in Phoenix 5.x) etc.
> While doing backports from 4.x to master and vice-versa, it's quite common
> for these branch specific imports rules to get ignored by devs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
