[
https://issues.apache.org/jira/browse/PHOENIX-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262601#comment-17262601
]
ASF GitHub Bot commented on PHOENIX-6309:
-----------------------------------------
stoty commented on pull request #1083:
URL: https://github.com/apache/phoenix/pull/1083#issuecomment-757899475
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 33s | 4.x passed |
| +1 :green_heart: | compile | 1m 44s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 18s | 4.x passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 43s | the patch passed |
| +1 :green_heart: | javac | 1m 43s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 1m 19s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 218m 44s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 58s | The patch does not generate
ASF License warnings. |
| | | 251m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1083/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1083 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux c95907b5c119 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23
18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 96ad05b |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1083/2/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1083/2/testReport/
|
| Max. process+thread count | 5402 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1083/2/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use maven enforcer to ban imports
> ---------------------------------
>
> Key: PHOENIX-6309
> URL: https://issues.apache.org/jira/browse/PHOENIX-6309
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> We are already using mvn enforcer plugin for hbase version evaluations. We
> can extend it's usage to restrict-imports-enforcer-rule enforcer and ban
> imports from illegal packages (as per our project guidelines)
> e.g restrict usage of org.apache.commons.logging, com.google.common (in the
> presence of phoenix-thirdparty in Phoenix 5.x) etc.
> While doing backports from 4.x to master and vice-versa, it's quite common
> for these branch specific imports rules to get ignored by devs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
