[
https://issues.apache.org/jira/browse/PHOENIX-6316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266000#comment-17266000
]
Istvan Toth commented on PHOENIX-6316:
--------------------------------------
BTW you may want to add this for less false positives:
{noformat}
diff --git dev/misc_utils/git_jira_fix_version_check.py
dev/misc_utils/git_jira_fix_version_check.py
index 0d1266f95..1e51dcd0d 100644
--- dev/misc_utils/git_jira_fix_version_check.py
+++ dev/misc_utils/git_jira_fix_version_check.py
@@ -77,7 +77,8 @@ for commit in subprocess.check_output(['git', 'log',
'--pretty=oneline']).decode
if not expected_fix_version:
print("Jira not present with version: " + fix_version + ". \t Commit:
" + commit)
continue
- if issue.fields.resolution is None or issue.fields.resolution.name !=
'Fixed':
+ if issue.fields.status is None or ( issue.fields.status.name != 'Resolved'
+ and issue.fields.status.name !=
'Closed' ):
print("Jira is not resolved yet? \t\t Commit: " + commit)
else:
# This means Jira corresponding to current commit message is resolved
with expected
{noformat}
> git_jira_fix_version_check.py should identify fixed Jira without any commit
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-6316
> URL: https://issues.apache.org/jira/browse/PHOENIX-6316
> Project: Phoenix
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
>
> Now that we have script git_jira_fix_version_check to identify all commits
> that have no corresponding Jira with expected fixVersion available, we should
> also let it figure out the diff the other way around i.e identify all Jiras
> that are marked resolved with given fixVersion but have no commit present
> with Jira number included.
> RC preparation also needs to find this diff because we don't want to provide
> extra Jira in CHANGELOG without any corresponding commits present on git
> (unless it is svn checkin and fixVersion is relevant).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
