[ 
https://issues.apache.org/jira/browse/PHOENIX-6316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266035#comment-17266035
 ] 

ASF GitHub Bot commented on PHOENIX-6316:
-----------------------------------------

stoty commented on pull request #1091:
URL: https://github.com/apache/phoenix/pull/1091#issuecomment-760935686


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   4m 19s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   4m 23s |  Maven dependency ordering for branch  |
   | +0 |  hbaserecompile  |  11m 16s |  HBase recompiled.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  8s |  Maven dependency ordering for patch  |
   | +0 |  hbaserecompile  |   7m 38s |  HBase recompiled.  |
   | -1 :x: |  markdownlint  |   0m  2s |  The patch generated 3 new + 35 
unchanged - 0 fixed = 38 total (was 35)  |
   | -1 :x: |  pylint  |   0m  3s |  The patch generated 3 new + 10 unchanged - 
0 fixed = 13 total (was 10)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no 
output?  |
   |  |   |  24m 12s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1091/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1091 |
   | Optional Tests | dupname asflicense pylint markdownlint |
   | uname | Linux f3cecdbc501c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 196c1a3 |
   | markdownlint | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1091/1/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
 |
   | pylint | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1091/1/artifact/yetus-general-check/output/diff-patch-pylint.txt
 |
   | Max. process+thread count | 96 (vs. ulimit of 30000) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1091/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 pylint=2.4.4 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> git_jira_fix_version_check.py should identify fixed Jira without any commit
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-6316
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6316
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 5.0.0
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.0
>
>
> Now that we have script git_jira_fix_version_check to identify all commits 
> that have no corresponding Jira with expected fixVersion available, we should 
> also let it figure out the diff the other way around i.e identify all Jiras 
> that are marked resolved with given fixVersion but have no commit present 
> with Jira number included.
> RC preparation also needs to find this diff because we don't want to provide 
> extra Jira in CHANGELOG without any corresponding commits present on git 
> (unless it is svn checkin and fixVersion is relevant).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to