virajjasani commented on a change in pull request #1096:
URL: https://github.com/apache/phoenix/pull/1096#discussion_r559600160
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolTimeRangeIT.java
##########
@@ -226,7 +225,8 @@ public void tickTime() {
}
@AfterClass
- public static synchronized void teardown() {
+ public static synchronized void teardown() throws Exception {
+ confirmStoreRefCountLeak();
Review comment:
Oh btw we don't need to worry about putting anything in finally after
calling BaseTest#confirmStoreRefCountLeak() because BaseTest is taking care of
shutting down miniCluster:
```
protected synchronized static void confirmStoreRefCountLeak()
throws Exception {
if (getUtility() != null) {
try {
CompatUtil.confirmStoreRefCountLeak(
getUtility().getAdmin());
} catch (IOException e) {
LOGGER.error("StoreFile refCount is leaked", e);
freeResources(false);
fail("StoreFile refCount is leaked");
}
}
}
```
freeResources() is doing the job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
