stoty commented on a change in pull request #1096:
URL: https://github.com/apache/phoenix/pull/1096#discussion_r559608940
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
##########
@@ -2006,4 +2015,21 @@ public void run() {
thread.setDaemon(true);
thread.start();
}
+
+ /**
+ * Confirms that no storeFile has refCount leakage
+ */
+ protected synchronized static void confirmStoreRefCountLeak()
+ throws Exception {
+ if (getUtility() != null) {
+ try {
+ CompatUtil.confirmStoreRefCountLeak(
+ getUtility().getAdmin());
+ } catch (IOException e) {
+ LOGGER.error("StoreFile refCount is leaked", e);
Review comment:
This is a rather unexpected side effect. I am not a fan of having the
freeResources logic called from a different place in the normal and the error
path.
Maybe call this method freeResourcesAndCheckRefCountLeak, and
call freeResources unconditionally from from finally here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
