[
https://issues.apache.org/jira/browse/PHOENIX-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267915#comment-17267915
]
ASF GitHub Bot commented on PHOENIX-6327:
-----------------------------------------
virajjasani commented on pull request #1099:
URL: https://github.com/apache/phoenix/pull/1099#issuecomment-762869708
+1 (non-binding), nice cleanup of the categories! While committing, you
might prefer fixing whitespace-eol?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Consolidate Junit test categories
> ---------------------------------
>
> Key: PHOENIX-6327
> URL: https://issues.apache.org/jira/browse/PHOENIX-6327
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Minor
>
> Phoenix has an HBaseManagedTimeTest category.
> However, there are only two pherf tests in this category, and I see no reason
> for thoseto have their own category.
> This looks like a leftover from some very old test setup.
> SplitSystemCatalogTests category works the same as the
> NeedTheirOwnClusterTests.
> Having separate categories hurts execution parallellism and increases test
> execution time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
