[
https://issues.apache.org/jira/browse/PHOENIX-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268232#comment-17268232
]
ASF GitHub Bot commented on PHOENIX-6327:
-----------------------------------------
stoty commented on pull request #1100:
URL: https://github.com/apache/phoenix/pull/1100#issuecomment-763145384
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 1s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 4m 59s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 15s | 4.x passed |
| +1 :green_heart: | compile | 1m 44s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 34s | 4.x passed |
| +1 :green_heart: | javadoc | 2m 20s | 4.x passed |
| +0 :ok: | spotbugs | 4m 35s | root in 4.x has 999 extant spotbugs
warnings. |
| +0 :ok: | spotbugs | 3m 6s | phoenix-core in 4.x has 945 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 53s | phoenix-pherf in 4.x has 42 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 57s | the patch passed |
| +1 :green_heart: | compile | 1m 40s | the patch passed |
| +1 :green_heart: | javac | 1m 40s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 34s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 5 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 2m 15s | the patch passed |
| +1 :green_heart: | spotbugs | 9m 14s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 358m 8s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 54s | The patch does not generate
ASF License warnings. |
| | | 420m 13s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.index.MutableIndexIT |
| | phoenix.tx.FlappingTransactionIT |
| | phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1100/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1100 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile xml |
| uname | Linux 0898859889f9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 6fe6052 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1100/1/artifact/yetus-general-check/output/whitespace-eol.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1100/1/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1100/1/testReport/
|
| Max. process+thread count | 4752 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1100/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Consolidate Junit test categories
> ---------------------------------
>
> Key: PHOENIX-6327
> URL: https://issues.apache.org/jira/browse/PHOENIX-6327
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Minor
> Fix For: 5.1.0, 4.16.1
>
>
> Phoenix has an HBaseManagedTimeTest category.
> However, there are only two pherf tests in this category, and I see no reason
> for thoseto have their own category.
> This looks like a leftover from some very old test setup.
> SplitSystemCatalogTests category works the same as the
> NeedTheirOwnClusterTests.
> Having separate categories hurts execution parallellism and increases test
> execution time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
