[
https://issues.apache.org/jira/browse/PHOENIX-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275322#comment-17275322
]
ASF GitHub Bot commented on PHOENIX-6349:
-----------------------------------------
stoty commented on a change in pull request #1122:
URL: https://github.com/apache/phoenix/pull/1122#discussion_r567079350
##########
File path: pom.xml
##########
@@ -82,7 +82,7 @@
<hadoop.version>3.1.4</hadoop.version>
<hbase.thirdparty.version>2.2.1</hbase.thirdparty.version>
- <phoenix.thirdparty.version>1.0.0</phoenix.thirdparty.version>
+ <phoenix.thirdparty.version>1.1.0-SNAPSHOT</phoenix.thirdparty.version>
Review comment:
We shouldn't release 4.16/5.1with snapshot dependecies.
We can either merge this now, and update when we release thirdparty 1.1.0,
or we can wait with the merge until we have 1.1.0 final.
I'm going to prepare an rc0 for thirdparty this weekend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add and use commons-cli to phoenix-thirdparty
> ---------------------------------------------
>
> Key: PHOENIX-6349
> URL: https://issues.apache.org/jira/browse/PHOENIX-6349
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> We are hit hard by commons-cli bugs, and currently we msut stick to the
> version used by HBase/Hadoop.
> Adding commons-cli to phoenix-thirdparty would unchain us from the
> Hbase/Hadoop version, and would let us add our own patches (modeled after
> protobuf in HBase)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
