[ 
https://issues.apache.org/jira/browse/PHOENIX-6349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275521#comment-17275521
 ] 

ASF GitHub Bot commented on PHOENIX-6349:
-----------------------------------------

yanxinyi edited a comment on pull request #1123:
URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770172946


   Huh, I'm getting the same error. 
   
   When I compared the 4.x and master server jars, the master branch server jar 
does have dependent classes but not 4.x. 
   
   Here is the list 
   org/apache/phoenix/shaded/org/apache/commons/cli/
   org/apache/phoenix/shaded/org/apache/commons/cli/GnuParser.class
   org/apache/phoenix/shaded/org/apache/commons/cli/HelpFormatter$1.class
   
org/apache/phoenix/shaded/org/apache/commons/cli/MissingArgumentException.class
   org/apache/phoenix/shaded/org/apache/commons/cli/Option$Builder.class
   org/apache/phoenix/shaded/org/apache/commons/cli/Options.class
   org/apache/phoenix/shaded/org/apache/commons/cli/PatternOptionBuilder.class
   org/apache/phoenix/shaded/org/apache/commons/cli/Util.class
   org/apache/phoenix/shaded/org/apache/commons/cli/BasicParser.class
   org/apache/phoenix/shaded/org/apache/commons/cli/CommandLineParser.class
   org/apache/phoenix/shaded/org/apache/commons/cli/HelpFormatter.class
   org/apache/phoenix/shaded/org/apache/commons/cli/OptionGroup.class
   org/apache/phoenix/shaded/org/apache/commons/cli/Parser.class
   
org/apache/phoenix/shaded/org/apache/commons/cli/UnrecognizedOptionException.class
   
org/apache/phoenix/shaded/org/apache/commons/cli/AlreadySelectedException.class
   org/apache/phoenix/shaded/org/apache/commons/cli/CommandLine$Builder.class
   org/apache/phoenix/shaded/org/apache/commons/cli/CommandLine.class
   
org/apache/phoenix/shaded/org/apache/commons/cli/HelpFormatter$OptionComparator.class
   org/apache/phoenix/shaded/org/apache/commons/cli/Option$1.class
   org/apache/phoenix/shaded/org/apache/commons/cli/OptionValidator.class
   org/apache/phoenix/shaded/org/apache/commons/cli/PosixParser.class
   META-INF/maven/commons-cli/
   META-INF/maven/commons-cli/commons-cli/
   META-INF/maven/commons-cli/commons-cli/pom.xml
   
org/apache/phoenix/shaded/org/apache/commons/cli/AmbiguousOptionException.class
   org/apache/phoenix/shaded/org/apache/commons/cli/DefaultParser.class
   org/apache/phoenix/shaded/org/apache/commons/cli/MissingOptionException.class
   org/apache/phoenix/shaded/org/apache/commons/cli/Option.class
   org/apache/phoenix/shaded/org/apache/commons/cli/OptionBuilder.class
   org/apache/phoenix/shaded/org/apache/commons/cli/ParseException.class
   org/apache/phoenix/shaded/org/apache/commons/cli/TypeHandler.class
   META-INF/maven/commons-cli/commons-cli/pom.properties
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Add and use commons-cli to phoenix-thirdparty
> ---------------------------------------------
>
>                 Key: PHOENIX-6349
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6349
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0, thirdparty-1.1.0
>
>
> We are hit hard by commons-cli bugs, and currently we msut stick to the 
> version used by HBase/Hadoop.
> Adding commons-cli to phoenix-thirdparty would unchain us from the 
> Hbase/Hadoop version, and would let us add our own patches (modeled after 
> protobuf in HBase)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to