stoty commented on pull request #1123: URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770178661
The difference is normal. In the 4.x server jar we add the shaded packages manually, and do not relocate. (Don't know why, probably historical reasons) In 4.x HEAD we don't add commons-cli, and use whatever HBase/Hadoop classpatch gives us. In master HEAD we add and shade every dependecy that isn't excluded and provided (including commons-cli), and relocate it under org/apache/phoenix/shaded . With this (updated) patch we add the org.apache.phoenix.thirdparty.org.apache.commons.cli classes on either branch. I've just run a test locally on the Phoenix 5 pseudodistributed cluster with this patch, and didn't get any errors. I am quite baffled why the same setup would cause problems on 4.x ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
