stoty commented on pull request #1123: URL: https://github.com/apache/phoenix/pull/1123#issuecomment-770234563
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 5m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 9m 55s | 4.x passed | | +1 :green_heart: | compile | 1m 29s | 4.x passed | | +1 :green_heart: | checkstyle | 1m 43s | 4.x passed | | +1 :green_heart: | javadoc | 2m 34s | 4.x passed | | +0 :ok: | spotbugs | 4m 12s | root in 4.x has 1000 extant spotbugs warnings. | | +0 :ok: | spotbugs | 2m 57s | phoenix-core in 4.x has 945 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 49s | phoenix-pherf in 4.x has 42 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 42s | phoenix-tools in 4.x has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 56s | the patch passed | | +1 :green_heart: | compile | 1m 34s | the patch passed | | +1 :green_heart: | javac | 1m 34s | the patch passed | | -1 :x: | checkstyle | 1m 42s | root: The patch generated 28 new + 2743 unchanged - 28 fixed = 2771 total (was 2771) | | -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 34s | the patch passed | | -1 :x: | spotbugs | 3m 12s | phoenix-core generated 9 new + 936 unchanged - 9 fixed = 945 total (was 945) | | -1 :x: | spotbugs | 1m 5s | phoenix-pherf generated 1 new + 41 unchanged - 1 fixed = 42 total (was 42) | | -1 :x: | spotbugs | 0m 57s | phoenix-tools generated 1 new + 2 unchanged - 1 fixed = 3 total (was 3) | | -1 :x: | spotbugs | 4m 27s | root generated 11 new + 989 unchanged - 11 fixed = 1000 total (was 1000) | ||| _ Other Tests _ | | -1 :x: | unit | 209m 28s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 47s | The patch does not generate ASF License warnings. | | | | 264m 22s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 134] | | | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 178] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] | | | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 875] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 362] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 236] | | | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 206] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 274] | | FindBugs | module:phoenix-pherf | | | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 208] | | FindBugs | module:phoenix-tools | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] | | FindBugs | module:root | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:cmdLine in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.parseOptions(String[]) on exception path Dereferenced at AbstractBulkLoadTool.java:[line 134] | | | Null passed for non-null parameter of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:of loadData(Configuration, CommandLine) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(String[]) Method invoked at AbstractBulkLoadTool.java:[line 178] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexScrutinyTool.parseOptions(String[]) on exception path Dereferenced at IndexScrutinyTool.java:[line 181] | | | org.apache.phoenix.mapreduce.index.IndexTool.populateIndexToolAttributes(CommandLine) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead At IndexTool.java:constructor; use Long.valueOf(String) instead At IndexTool.java:[line 875] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexTool.parseOptions(String[]) on exception path Dereferenced at IndexTool.java:[line 362] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:cmdLine in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.parseOptions(String[]) on exception path Dereferenced at IndexUpgradeTool.java:[line 236] | | | Null passed for non-null parameter of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:of initializeTool(CommandLine) in org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(String[]) Method invoked at IndexUpgradeTool.java:[line 206] | | | Boxing/unboxing to parse a primitive org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:org.apache.phoenix.pherf.Pherf.getLogPerNRow(CommandLine) At Pherf.java:[line 208] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:cmdLine in org.apache.phoenix.schema.SchemaExtractionTool.parseOptions(String[]) on exception path Dereferenced at SchemaExtractionTool.java:[line 94] | | | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:cmdLine in org.apache.phoenix.schema.stats.UpdateStatisticsTool.parseOptions(String[]) on exception path Dereferenced at UpdateStatisticsTool.java:[line 274] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1123 | | Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle | | uname | Linux ac48a4eb3666 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 31a8f59 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/whitespace-tabs.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/new-spotbugs-root.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/testReport/ | | Max. process+thread count | 5708 (vs. ulimit of 30000) | | modules | C: phoenix-core phoenix-pherf phoenix-server phoenix-tools . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1123/4/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
