[
https://issues.apache.org/jira/browse/PHOENIX-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278126#comment-17278126
]
ASF GitHub Bot commented on PHOENIX-6360:
-----------------------------------------
stoty commented on pull request #1129:
URL: https://github.com/apache/phoenix/pull/1129#issuecomment-772634954
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 0s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 57s | 4.x passed |
| +1 :green_heart: | compile | 2m 27s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 17s | 4.x passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 52s | the patch passed |
| +1 :green_heart: | compile | 2m 23s | the patch passed |
| +1 :green_heart: | javac | 2m 23s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 1m 16s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 130m 6s | phoenix-core in the patch passed.
|
| +1 :green_heart: | unit | 0m 33s | phoenix-client-parent in the patch
passed. |
| +1 :green_heart: | unit | 0m 44s | phoenix-server in the patch
passed. |
| +1 :green_heart: | unit | 0m 44s | phoenix-assembly in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 33s | The patch does not generate
ASF License warnings. |
| | | 162m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1129/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1129 |
| Optional Tests | dupname asflicense xml javac javadoc unit compile |
| uname | Linux a7d7b636d9e5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 68bd519 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1129/2/testReport/
|
| Max. process+thread count | 5656 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-client-parent phoenix-server
phoenix-assembly U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1129/2/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> phoenix-core has compile dependency on phoenix-hbase-compat
> -----------------------------------------------------------
>
> Key: PHOENIX-6360
> URL: https://issues.apache.org/jira/browse/PHOENIX-6360
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Blocker
>
> We are adding phoenix-hbase-compat-X.X.X to phoenix-core as a dependency.
> phoenix-core is supposed to be hbase profile neutral, and the consumer shoudl
> add their the phoenix-hbase-compat-X.X.X module manually.
> This breaks, or requires ugly workarounds in consumers of phoenix-core, like
> phoenix-connectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
