[
https://issues.apache.org/jira/browse/PHOENIX-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278149#comment-17278149
]
ASF GitHub Bot commented on PHOENIX-6360:
-----------------------------------------
virajjasani commented on a change in pull request #1129:
URL: https://github.com/apache/phoenix/pull/1129#discussion_r569564421
##########
File path: phoenix-assembly/src/build/components/all-common-dependencies.xml
##########
@@ -28,6 +28,8 @@
<unpack>false</unpack>
<outputDirectory>/lib</outputDirectory>
<includes>
+
<include>org.apache.phoenix:phoenix-hbase-compat-${hbase.compat.version}</include>
Review comment:
I think this is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> phoenix-core has compile dependency on phoenix-hbase-compat
> -----------------------------------------------------------
>
> Key: PHOENIX-6360
> URL: https://issues.apache.org/jira/browse/PHOENIX-6360
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Blocker
>
> We are adding phoenix-hbase-compat-X.X.X to phoenix-core as a dependency.
> phoenix-core is supposed to be hbase profile neutral, and the consumer shoudl
> add their the phoenix-hbase-compat-X.X.X module manually.
> This breaks, or requires ugly workarounds in consumers of phoenix-core, like
> phoenix-connectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
