gokceni commented on a change in pull request #1170:
URL: https://github.com/apache/phoenix/pull/1170#discussion_r605277282



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
##########
@@ -1586,7 +1635,12 @@ public synchronized boolean 
getIndexMaintainers(ImmutableBytesWritable ptr, Phoe
 
     @Override
     public PName getPhysicalName() {
+        // For views, physicalName is base table name. There might be a case 
where the Phoenix table is pointing to another physical table.

Review comment:
       physical. Will update

##########
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
##########
@@ -1586,7 +1635,12 @@ public synchronized boolean 
getIndexMaintainers(ImmutableBytesWritable ptr, Phoe
 
     @Override
     public PName getPhysicalName() {
+        // For views, physicalName is base table name. There might be a case 
where the Phoenix table is pointing to another physical table.

Review comment:
       physical. Will update the comment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to