stoty commented on pull request #1170: URL: https://github.com/apache/phoenix/pull/1170#issuecomment-812226102
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x-PHOENIX-6247 Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 17s | 4.x-PHOENIX-6247 passed | | +1 :green_heart: | compile | 1m 6s | 4.x-PHOENIX-6247 passed | | +1 :green_heart: | checkstyle | 4m 10s | 4.x-PHOENIX-6247 passed | | +1 :green_heart: | javadoc | 0m 49s | 4.x-PHOENIX-6247 passed | | +0 :ok: | spotbugs | 3m 15s | phoenix-core in 4.x-PHOENIX-6247 has 941 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 56s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | cc | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -1 :x: | checkstyle | 4m 12s | phoenix-core: The patch generated 284 new + 13755 unchanged - 151 fixed = 14039 total (was 13906) | | +1 :green_heart: | prototool | 0m 1s | There were no new prototool issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 48s | the patch passed | | -1 :x: | spotbugs | 3m 31s | phoenix-core generated 5 new + 941 unchanged - 0 fixed = 946 total (was 941) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 194m 47s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 238m 23s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.createTable(RpcController, MetaDataProtos$CreateTableRequest, RpcCallback): String.getBytes() At MetaDataEndpointImpl.java:[line 1929] | | | Found reliance on default encoding in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int):in org.apache.phoenix.coprocessor.MetaDataEndpointImpl.getTable(RegionScanner, long, long, int): String.getBytes() At MetaDataEndpointImpl.java:[line 1237] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.PHYSICAL_TABLE_NAME_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 326] | | | Found reliance on default encoding in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean):in org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureViewIndexTableCreated(PTable, long, boolean): String.getBytes() At ConnectionQueryServicesImpl.java:[line 2250] | | | Call to String.equals(org.apache.phoenix.schema.PName) in org.apache.phoenix.schema.MetaDataClient.evaluateStmtProperties(MetaDataClient$MetaProperties, MetaDataClient$MetaPropertiesEvaluated, PTable, String, String) At MetaDataClient.java:MetaDataClient$MetaPropertiesEvaluated, PTable, String, String) At MetaDataClient.java:[line 5419] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1170 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool | | uname | Linux 6abf6bf7fa1b 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x-PHOENIX-6247 / ee4ce9f | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/testReport/ | | Max. process+thread count | 5161 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1170/13/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
