gjacoby126 commented on a change in pull request #1216:
URL: https://github.com/apache/phoenix/pull/1216#discussion_r625242627
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java
##########
@@ -1166,6 +1166,31 @@ public void testTableDescriptorPriority() throws
SQLException, IOException {
}
}
+ @Test
+ public void testCreateTableSchemaVersion() throws Exception {
+ Properties props = new Properties();
+ final String schemaName = generateUniqueName();
+ final String tableName = generateUniqueName();
+ final String version = "V1.0";
+ try (Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ testCreateTableSchemaVersionHelper(conn, schemaName, tableName,
version);
+ }
+ }
+
+ public static void testCreateTableSchemaVersionHelper(Connection conn,
String schemaName, String tableName,
+ String
dataTableVersion)
+ throws Exception {
+ final String dataTableFullName = SchemaUtil.getTableName(schemaName,
tableName);
+ String ddl =
+ "CREATE TABLE " + dataTableFullName + " (\n" + "ID1
VARCHAR(15) NOT NULL,\n"
Review comment:
It appears there's a rule in Phoenix grammar which prevents setting
table level properties (like schema version) while adding a column, which means
that when adding a column you'd need a separate ALTER TABLE SET SCHEMA_VERSION
statement. Not ideal, but I was trying to avoid large changes in the plumbing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
