gjacoby126 commented on a change in pull request #1216:
URL: https://github.com/apache/phoenix/pull/1216#discussion_r625290041



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -3055,6 +3059,12 @@ public boolean isViewReferenced() {
                 tableUpsert.setString(33, physicalTableName);
             }
 
+            if (schemaVersion == null) {
+                tableUpsert.setNull(34, Types.VARCHAR);

Review comment:
       I'd considered it but decided against the idea because I didn't want to 
proscribe a particular versioning scheme...the idea is that a particular 
organization can choose their own version stamps (and that they don't have to 
if they don't want to, hence default null)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to