[
https://issues.apache.org/jira/browse/PHOENIX-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341218#comment-17341218
]
ASF GitHub Bot commented on PHOENIX-6397:
-----------------------------------------
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-835169490
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 57s | 4.x passed |
| +1 :green_heart: | compile | 1m 3s | 4.x passed |
| +1 :green_heart: | checkstyle | 3m 2s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in 4.x has 945 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 41s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 3m 22s | phoenix-core: The patch generated 709
new + 6124 unchanged - 86 fixed = 6833 total (was 6210) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| -1 :x: | spotbugs | 3m 17s | phoenix-core generated 5 new + 945
unchanged - 0 fixed = 950 total (was 945) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 140m 41s | phoenix-core in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 12s | The patch does not generate
ASF License warnings. |
| | | 178m 35s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in
org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At
TableMetricsManager.java:in
org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At
TableMetricsManager.java:[line 88] |
| | Write to static field
org.apache.phoenix.monitoring.TableMetricsManager.options from instance method
new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At
TableMetricsManager.java:from instance method new
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At
TableMetricsManager.java:[line 57] |
| | Write to static field
org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from
instance method new
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At
TableMetricsManager.java:from instance method new
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At
TableMetricsManager.java:[line 69] |
| | Write to static field
org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled
from instance method new
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At
TableMetricsManager.java:from instance method new
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At
TableMetricsManager.java:[line 58] |
| | Write to static field
org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping
from instance method new
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At
TableMetricsManager.java:from instance method new
org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At
TableMetricsManager.java:[line 61] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 994a97116f92 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 6d6bf9a |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/testReport/
|
| Max. process+thread count | 5648 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement TableMetricsManager class and its associated functions for select.
> upsert and Delete Queries
> ------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6397
> URL: https://issues.apache.org/jira/browse/PHOENIX-6397
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: vikas meka
> Assignee: vikas meka
> Priority: Major
> Fix For: 4.17.0, 5.2.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
