[
https://issues.apache.org/jira/browse/PHOENIX-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342191#comment-17342191
]
ASF GitHub Bot commented on PHOENIX-6397:
-----------------------------------------
yanxinyi commented on a change in pull request #1224:
URL: https://github.com/apache/phoenix/pull/1224#discussion_r629747101
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
##########
@@ -684,6 +692,33 @@ public boolean isGlobalMetricsEnabled() {
return config.getBoolean(GLOBAL_METRICS_ENABLED,
DEFAULT_IS_GLOBAL_METRICS_ENABLED);
}
+ public String getMetricPublisherClass() {
+ return config.get(METRIC_PUBLISHER_CLASS_NAME,
DEFAULT_METRIC_PUBLISHER_CLASS_NAME);
+ }
+
+ public String getAllowedListTableNames() {
+ return config.get(ALLOWED_LIST_FOR_TABLE_LEVEL_METRICS,
+ DEFAULT_ALLOWED_LIST_FOR_TABLE_LEVEL_METRICS);
+ }
+
+ public boolean isTableLevelMetricsEnabled() {
+ return config
+ .getBoolean(TABLE_LEVEL_METRICS_ENABLED,
DEFAULT_IS_TABLE_LEVEL_METRICS_ENABLED);
+ }
+
+ public void setTableLevelMetricsEnabled() {
+ set(TABLE_LEVEL_METRICS_ENABLED, true);
+ }
+
+ public boolean isMetricPublisherEnabled() {
+ return config.getBoolean(METRIC_PUBLISHER_ENABLED,
DEFAULT_IS_METRIC_PUBLISHER_ENABLED);
+ }
+
+ public void setAllowedListForTableLevelMetrics(String tableNameList){
Review comment:
VisibleForTesting tag has been added on 4.x branch but not here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement TableMetricsManager class and its associated functions for select.
> upsert and Delete Queries
> ------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6397
> URL: https://issues.apache.org/jira/browse/PHOENIX-6397
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: vikas meka
> Assignee: vikas meka
> Priority: Major
> Fix For: 4.17.0, 5.2.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
