yanxinyi commented on a change in pull request #1224:
URL: https://github.com/apache/phoenix/pull/1224#discussion_r629745504
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/MutationMetricQueue.java
##########
@@ -119,14 +178,57 @@ public CombinableMetric
getNumOfIndexCommitFailedMutations() {
return numOfIndexCommitFailMutations;
}
+ public CombinableMetric getUpsertMutationsSizeBytes() {
+ return upsertMutationsSizeBytes;
+ }
+
+ public CombinableMetric getDeleteMutationsSizeBytes() {
+ return deleteMutationsSizeBytes;
+ }
+
+ public CombinableMetric getUpsertMutationSqlCounterSuccess() {
+ return upsertMutationSqlCounterSuccess;
+ }
+
+ public CombinableMetric getDeleteMutationSqlCounterSuccess() {
+ return deleteMutationSqlCounterSuccess;
+ }
+
+ public CombinableMetric getUpsertBatchFailedSize() {
+ return upsertBatchFailedSize;
+ }
+
+ public CombinableMetric getUpsertBatchFailedCounter() {
+ return upsertBatchFailedCounter;
+ }
+
+ public CombinableMetric getDeleteBatchFailedSize() {
+ return deleteBatchFailedSize;
+ }
+
+ public CombinableMetric getDeleteBatchFailedCounter() {
+ return deleteBatchFailedCounter;
+ }
+
public void combineMetric(MutationMetric other) {
this.numMutations.combine(other.numMutations);
- this.mutationsSizeBytes.combine(other.mutationsSizeBytes);
+
this.totalCommitTimeForUpserts.combine(other.totalCommitTimeForUpserts);
+
this.totalCommitTimeForDeletes.combine(other.totalCommitTimeForDeletes);
this.totalCommitTimeForMutations.combine(other.totalCommitTimeForMutations);
this.numFailedMutations.combine(other.numFailedMutations);
this.numOfIndexCommitFailMutations.combine(other.numOfIndexCommitFailMutations);
+
this.upsertMutationsSizeBytes.combine(other.upsertMutationsSizeBytes);
+
this.deleteMutationsSizeBytes.combine(other.deleteMutationsSizeBytes);
+ this.mutationsSizeBytes.combine(other.mutationsSizeBytes);
+
this.upsertMutationSqlCounterSuccess.combine(other.upsertMutationSqlCounterSuccess);
+
this.deleteMutationSqlCounterSuccess.combine(other.deleteMutationSqlCounterSuccess);
+ this.upsertBatchFailedSize.combine(other.upsertBatchFailedSize);
+
this.upsertBatchFailedCounter.combine(other.upsertBatchFailedCounter);
+ this.deleteBatchFailedSize.combine(other.deleteBatchFailedSize);
+
this.deleteBatchFailedCounter.combine(other.deleteBatchFailedCounter);
}
+
Review comment:
nit:extra line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
