yanxinyi commented on a change in pull request #1224:
URL: https://github.com/apache/phoenix/pull/1224#discussion_r629747889
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java
##########
@@ -1367,6 +1369,22 @@ private static Expression
getFirstPKColumnExpression(PTable table) throws SQLExc
public static Collection<GlobalMetric> getGlobalPhoenixClientMetrics() {
return GlobalClientMetrics.getMetrics();
}
+
+ /**
+ * This function will be called mainly in Metric Publisher methods.
+ * Its the only way Metric publisher will be able to access the metrics in
phoenix system.
+ * @return map of TableName to List of GlobalMetric's.
+ */
+ public static Map<String,List<PhoenixTableMetric>>
getPhoenixTableClientMetrics() {
+ return TableMetricsManager.getTableMetricsMethod();
+ }
+
+ /**
+ * This is only used in testcases to reset the tableLevel Metrics data
+ */
+ public static void clearTableLevelMetrics(){
Review comment:
VisibleForTesting has been added on 4.x but not here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]