gokceni commented on a change in pull request #1228:
URL: https://github.com/apache/phoenix/pull/1228#discussion_r630606919
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -357,6 +361,7 @@ public boolean next(List<Cell> results) throws IOException {
} catch (Throwable e) {
LOGGER.error("Exception in IndexRebuildRegionScanner for region "
+ region.getRegionInfo().getRegionNameAsString(), e);
+ this.shouldRetry = true;
Review comment:
Actually this is the only path where we set this variable. Any exception
in verify or rebuild or region split or move in this loop will set it. I am not
sure how we can detect just the successful case since we don't know the success
case as you said. What do we consider as success case? So I think leaving it
like this will cover most of the exception cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
