kadirozde commented on a change in pull request #1228:
URL: https://github.com/apache/phoenix/pull/1228#discussion_r630629270
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -357,6 +361,7 @@ public boolean next(List<Cell> results) throws IOException {
} catch (Throwable e) {
LOGGER.error("Exception in IndexRebuildRegionScanner for region "
+ region.getRegionInfo().getRegionNameAsString(), e);
+ this.shouldRetry = true;
Review comment:
I think instead of the exception approach and defining a new field
shouldRetry, we can use the existing hasMore field and pass hasMore instead
shouldRetry to logToIndexToolResultTable().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
