stoty commented on pull request #1231: URL: https://github.com/apache/phoenix/pull/1231#issuecomment-844862590
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 5m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 10m 31s | 4.x passed | | +1 :green_heart: | compile | 1m 41s | 4.x passed | | +1 :green_heart: | checkstyle | 2m 6s | 4.x passed | | +1 :green_heart: | javadoc | 1m 57s | 4.x passed | | +0 :ok: | spotbugs | 4m 40s | root in 4.x has 1020 extant spotbugs warnings. | | +0 :ok: | spotbugs | 3m 15s | phoenix-core in 4.x has 951 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 0s | the patch passed | | +1 :green_heart: | compile | 1m 39s | the patch passed | | +1 :green_heart: | javac | 1m 39s | the patch passed | | -1 :x: | checkstyle | 2m 16s | root: The patch generated 383 new + 5877 unchanged - 49 fixed = 6260 total (was 5926) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 1m 58s | the patch passed | | -1 :x: | spotbugs | 3m 33s | phoenix-core generated 4 new + 951 unchanged - 0 fixed = 955 total (was 951) | | -1 :x: | spotbugs | 4m 56s | root generated 4 new + 1020 unchanged - 0 fixed = 1024 total (was 1020) | ||| _ Other Tests _ | | -1 :x: | unit | 192m 20s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 18s | The patch does not generate ASF License warnings. | | | | 249m 11s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32] | | | org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75] | | | new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41] | | | org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32] | | FindBugs | module:root | | | org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32] | | | org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75] | | | new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41] | | | org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32] | | Failed junit tests | phoenix.end2end.AuditLoggingIT | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1231 | | Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle | | uname | Linux 1e50b46f9dee 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 69a9ec3 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/new-spotbugs-root.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/testReport/ | | Max. process+thread count | 5233 (vs. ulimit of 30000) | | modules | C: phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
