dbwong commented on a change in pull request #1231:
URL: https://github.com/apache/phoenix/pull/1231#discussion_r724623062
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/HistogramDistributionImpl.java
##########
@@ -26,23 +26,11 @@
private long count;
private Map<String, Long> rangeDistribution;
- public HistogramDistributionImpl(String histoName) {
+ public HistogramDistributionImpl(String histoName, long min, long max,
long count, Map<String, Long> distributionMap ) {
Review comment:
nit: final for the members?
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/TableHistograms.java
##########
@@ -104,16 +103,24 @@ public SizeHistogram getDeleteSizeHisto() {
}
public List<HistogramDistribution> getTableLatencyHistogramsDistribution()
{
- List<HistogramDistribution> list = new
ArrayList<>(Arrays.asList(queryLatencyHisto.getRangeHistogramDistribution(),
- upsertLatencyHisto.getRangeHistogramDistribution(),
deleteLatencyHisto.getRangeHistogramDistribution(),
- pointLookupLatencyHisto.getRangeHistogramDistribution(),
rangeScanLatencyHisto.getRangeHistogramDistribution()));
+ ImmutableList<HistogramDistribution>
+ list =
+
ImmutableList.of(queryLatencyHisto.getRangeHistogramDistribution(),
+ upsertLatencyHisto.getRangeHistogramDistribution(),
+ deleteLatencyHisto.getRangeHistogramDistribution(),
+
pointLookupLatencyHisto.getRangeHistogramDistribution(),
+ rangeScanLatencyHisto.getRangeHistogramDistribution());
return Collections.unmodifiableList(list);
Review comment:
You don't know this unmodifiable list now that you are using
ImmutableList.of
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
