[
https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354274#comment-17354274
]
ASF GitHub Bot commented on PHOENIX-6378:
-----------------------------------------
stoty commented on a change in pull request #1239:
URL: https://github.com/apache/phoenix/pull/1239#discussion_r642289833
##########
File path: bin/sqlline.py
##########
@@ -108,7 +108,9 @@ def kill_child():
colorSetting = "false"
java_cmd = java + ' $PHOENIX_OPTS ' + \
- ' -cp "' + hbase_config_path + os.pathsep + phoenix_utils.hbase_conf_dir +
os.pathsep + phoenix_utils.phoenix_client_jar + \
+ ' -cp "' + phoenix_utils.sqlline_with_deps_jar + os.pathsep +
hbase_config_path + os.pathsep + \
+ phoenix_utils.slf4j_jar + os.pathsep + \
Review comment:
this variable name hasn't been updated.
##########
File path: bin/phoenix_utils.py
##########
@@ -216,3 +232,4 @@ def common_sqlline_args(parser):
print("phoenix_loadbalancer_jar:", phoenix_loadbalancer_jar)
print("phoenix_thin_client_jar:", phoenix_thin_client_jar)
print("hadoop_classpath:", hadoop_classpath)
+ print("sqlline_with_deps_jar", sqlline_with_deps_jar)
Review comment:
We should log the slf4j_log4j12 jar name too.
##########
File path: bin/phoenix_utils.py
##########
@@ -176,6 +182,16 @@ def setPath():
if phoenix_pherf_jar == "":
phoenix_pherf_jar =
findFileInPathWithoutRecursion(PHOENIX_PHERF_JAR_PATTERN,
os.path.join(current_dir, ".."))
+ global sqlline_with_deps_jar
+ sqlline_with_deps_jar = os.environ.get(OVERRIDE_SQLLINE)
+ if sqlline_with_deps_jar is None or sqlline_with_deps_jar == "":
+ sqlline_with_deps_jar =
findFileInPathWithoutRecursion(SQLLINE_WITH_DEPS_PATTERN,
os.path.join(current_dir, "..","lib"))
+
+ global slf4j_jar
Review comment:
this variable name hasn't been updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py
> ------------------------------------------------------------------------
>
> Key: PHOENIX-6378
> URL: https://issues.apache.org/jira/browse/PHOENIX-6378
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Richárd Antal
> Priority: Major
>
> Ship sqlline separately, and adjust sqlline.py to load it.
> FYI [~dbwong]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
