[ 
https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354352#comment-17354352
 ] 

ASF GitHub Bot commented on PHOENIX-6378:
-----------------------------------------

stoty commented on pull request #1239:
URL: https://github.com/apache/phoenix/pull/1239#issuecomment-851373945


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   5m 57s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  11m 23s |  master passed  |
   | +0 |  hbaserecompile  |  24m  5s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 32s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 58s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   8m  1s |  root in the patch failed.  |
   | +0 |  hbaserecompile  |  14m 49s |  HBase recompiled.  |
   | -1 :x: |  compile  |   1m 30s |  root in the patch failed.  |
   | -1 :x: |  javac  |   1m 30s |  root in the patch failed.  |
   | -1 :x: |  pylint  |   0m  8s |  The patch generated 22 new + 115 unchanged 
- 10 fixed = 137 total (was 125)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  8s |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   1m 23s |  root in the patch failed.  |
   | -1 :x: |  javadoc  |   0m 14s |  phoenix-assembly in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 119m 14s |  root in the patch failed.  |
   | -1 :x: |  asflicense  |   2m 21s |  The patch generated 614 ASF License 
warnings.  |
   |  |   | 171m 32s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1239 |
   | Optional Tests | dupname asflicense pylint javac javadoc unit xml compile |
   | uname | Linux 911b11d27d92 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 5c94168 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/patch-compile-root.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/patch-compile-root.txt
 |
   | pylint | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/diff-patch-pylint.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/patch-javadoc-root.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/testReport/
 |
   | asflicense | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 12800 (vs. ulimit of 30000) |
   | modules | C: phoenix-client-parent/phoenix-client-embedded . 
phoenix-assembly U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1239/4/console
 |
   | versions | git=2.7.4 maven=3.3.9 pylint=2.4.4 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-6378
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6378
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 5.1.0, 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Richárd Antal
>            Priority: Major
>
> Ship sqlline separately, and adjust sqlline.py to load it.
> FYI [~dbwong]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to