stoty commented on code in PR #1486:
URL: https://github.com/apache/phoenix/pull/1486#discussion_r945447631
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java:
##########
@@ -175,27 +175,25 @@ protected static Map<String,String> getServerProps(){
return serverProps;
}
- @Parameters(name =
"MutableIndexFailureIT_transactionProvider={0},localIndex={1},isNamespaceMapped={2},disableIndexOnWriteFailure={3},failRebuildTask={4},throwIndexWriteFailure={5}")
// name is used by failsafe as file name in reports
+ // name is used by failsafe as file name in reports
+ @Parameters(name =
"MutableIndexFailureIT_transactionProvider={0},localIndex={1},isNamespaceMapped={2},disableIndexOnWriteFailure={3},failRebuildTask={4},throwIndexWriteFailure={5}")
public static synchronized Collection<Object[]> data() {
- return TestUtil.filterTxParamData(
- Arrays.asList(new Object[][] {
- // note - can't disableIndexOnWriteFailure without
throwIndexWriteFailure, PHOENIX-4130
- { null, false, false, false, false, false},
- { null, false, false, true, false, null},
- { "TEPHRA", false, false, true, false, null},
- { "OMID", false, false, true, false, null},
- { null, true, false, null, false, null},
- { "TEPHRA", true, false, true, false, null},
- { null, false, false, false, false, null},
- { null, true, false, false, false, null},
- { null, false, false, false, false, null},
- { null, false, false, true, false, null},
- { null, true, false, true, false, null},
- { null, true, false, true, false, null},
- { null, false, false, true, true, null},
- { null, false, false, false, true, false},
- }), 0);
-
+ return Arrays.asList(new Object[][] {
+ // Note: Can't disableIndexOnWriteFailure without
throwIndexWriteFailure, PHOENIX-4130
+ { null, false, false, false, false, false},
+ { null, false, false, true, false, null},
+ // Note: OMID does not support local indexes
+ { "OMID", false, false, true, false, null},
+ { null, true, false, null, false, null},
Review Comment:
We could a namespace mapped OMID combination here.
(Though I'm not sure if this test makes a lot of sense anymore with the new
indexing.)
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/NoLookbackMutableIndexExtendedIT.java:
##########
@@ -93,11 +93,11 @@ protected static Connection getConnection() throws
SQLException {
@Parameterized.Parameters(name =
"NoLookbackMutableIndexExtendedIT_localIndex={0},transactionProvider={1},columnEncoded={2}")
// name is used by failsafe as file name in reports
public static Collection<Object[]> data() {
- return TestUtil.filterTxParamData(Arrays.asList(
- new Object[][] { { false, null, false }, { false, null, true },
- { false, "TEPHRA", false }, { false, "TEPHRA", true },
- { false, "OMID", false }, { true, null, false }, {
true, null, true },
- { true, "TEPHRA", false }, { true, "TEPHRA", true },
}), 1);
+ return Arrays.asList(
+ // OMID does not support local indexes
+ new Object[][] { { false, null, false }, { false, null, true },
+ { false, "OMID", false }, { false, "OMID", true },
Review Comment:
OMID doesn't support column encoded tables, { false, "OMID", true } is not a
valid combination, as you've already noted elsewhere.
##########
phoenix-core/src/main/java/org/apache/phoenix/transaction/NotAvailableTransactionProvider.java:
##########
@@ -29,7 +29,7 @@
public class NotAvailableTransactionProvider implements
PhoenixTransactionProvider {
private static final NotAvailableTransactionProvider INSTANCE = new
NotAvailableTransactionProvider();
- private static final String message="This Phoenix has been built without
Tephra support";
+ private static final String message = "This Phoenix has been built without
Tephra support";
Review Comment:
Nit: Change the string ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
