gjacoby126 commented on code in PR #1486:
URL: https://github.com/apache/phoenix/pull/1486#discussion_r946046547
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java:
##########
@@ -175,27 +175,25 @@ protected static Map<String,String> getServerProps(){
return serverProps;
}
- @Parameters(name =
"MutableIndexFailureIT_transactionProvider={0},localIndex={1},isNamespaceMapped={2},disableIndexOnWriteFailure={3},failRebuildTask={4},throwIndexWriteFailure={5}")
// name is used by failsafe as file name in reports
+ // name is used by failsafe as file name in reports
+ @Parameters(name =
"MutableIndexFailureIT_transactionProvider={0},localIndex={1},isNamespaceMapped={2},disableIndexOnWriteFailure={3},failRebuildTask={4},throwIndexWriteFailure={5}")
public static synchronized Collection<Object[]> data() {
- return TestUtil.filterTxParamData(
- Arrays.asList(new Object[][] {
- // note - can't disableIndexOnWriteFailure without
throwIndexWriteFailure, PHOENIX-4130
- { null, false, false, false, false, false},
- { null, false, false, true, false, null},
- { "TEPHRA", false, false, true, false, null},
- { "OMID", false, false, true, false, null},
- { null, true, false, null, false, null},
- { "TEPHRA", true, false, true, false, null},
- { null, false, false, false, false, null},
- { null, true, false, false, false, null},
- { null, false, false, false, false, null},
- { null, false, false, true, false, null},
- { null, true, false, true, false, null},
- { null, true, false, true, false, null},
- { null, false, false, true, true, null},
- { null, false, false, false, true, false},
- }), 0);
-
+ return Arrays.asList(new Object[][] {
+ // Note: Can't disableIndexOnWriteFailure without
throwIndexWriteFailure, PHOENIX-4130
+ { null, false, false, false, false, false},
+ { null, false, false, true, false, null},
+ // Note: OMID does not support local indexes
+ { "OMID", false, false, true, false, null},
+ { null, true, false, null, false, null},
Review Comment:
We still technically support the old indexes I think (and probably have to
so long as we support upgrading from pre-4.15 versions, since you can't upgrade
your indexes until you get that far.) so it makes sense to have tests for the
failure-disable-rebuild paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
