richardantal commented on code in PR #1501:
URL: https://github.com/apache/phoenix/pull/1501#discussion_r973606768
##########
phoenix-core/src/main/java/org/apache/phoenix/util/DateUtil.java:
##########
@@ -72,13 +74,26 @@ public class DateUtil {
public static final String DEFAULT_TIMESTAMP_FORMAT =
DEFAULT_MS_DATE_FORMAT;
public static final Format DEFAULT_TIMESTAMP_FORMATTER =
DEFAULT_MS_DATE_FORMATTER;
- private static final DateTimeFormatter JULIAN_DATE_TIME_FORMATTER = new
DateTimeFormatterBuilder()
- .append(ISODateTimeFormat.dateParser())
- .appendOptional(new DateTimeFormatterBuilder()
- .appendLiteral(' ').toParser())
- .appendOptional(new DateTimeFormatterBuilder()
- .append(ISODateTimeFormat.timeParser()).toParser())
- .toFormatter().withChronology(GJChronology.getInstanceUTC());
+ private static final DateTimeFormatter ISO_DATE_TIME_FORMATTER = new
DateTimeFormatterBuilder()
Review Comment:
This is good question.
If we use IsoChronology we would face PHOENIX-6486 again.
I found that BritishCutoverChronology was the closest to the gregorian
julian chronology that we have and all the tests passed. I have to check the
dates between 1582 and 1752, and maybe implement a Gregorian chronology for
java time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
