gjacoby126 commented on PR #1501: URL: https://github.com/apache/phoenix/pull/1501#issuecomment-1263985132
@richardantal - I see that I missed a bunch of discussion back in PHOENIX-6486, but I'm not yet convinced that having an equivalent to GJChronology / BritishCutoverChronology is the right design. It looks like some other databases, such as MySQL, just use the Gregorian calendar for all time and require users to make adjustments. (See https://dev.mysql.com/doc/refman/8.0/en/mysql-calendar.html). This pushes potentially annoying conversions on our users, but I think the user is the only one who can actually do this correctly. That's because the exact calendar in use on a particular date is going to be use-case and culturally-specific -- there's no one right answer. GJChronology is going to be "right" for areas that were part of the Spanish Empire and a few other countries in 1582 and wrong for everyone else. (Even some countries, like France, that adopted the Gregorian calendar in 1582 didn't do it on the same _day_ that GJChronology assumes.) BritishCutoverChronology is going to be "right" for areas that were a part of the British Empire in 1752, but nowhere else. (See https://en.wikipedia.org/wiki/List_of_adoption_dates_of_the_Gregorian_calendar_by_country) Perhaps we can make it configurable, but I don't see a way to use any single calendar other than the ISO calendar, as MySQL does, as a one-size-fits-all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
