[
https://issues.apache.org/jira/browse/PHOENIX-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634506#comment-17634506
]
ASF GitHub Bot commented on PHOENIX-6818:
-----------------------------------------
gjacoby126 commented on code in PR #1527:
URL: https://github.com/apache/phoenix/pull/1527#discussion_r1023208846
##########
phoenix-core/src/main/java/org/apache/phoenix/util/i18n/OracleUpper.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.util.i18n;
+
+import org.apache.commons.lang3.StringUtils;
+
+/**
+ * This utility class was partially copied from Salesforce's
internationalization utility library
+ * (com.salesforce.i18n:i18n-util:1.0.4), which was released under the
3-clause BSD License.
+ * The i18n-util library is not maintained anymore, and it was using
vulnerable dependencies.
+ * For more info, see: https://issues.apache.org/jira/browse/PHOENIX-6818
+ *
+ * OracleUpper is used in combination with OracleUpperTable to generate
upper-case output
+ * consistent particular chosen Oracle expressions.
+ *
+ * @see OracleUpperTable
+ */
+public class OracleUpper {
Review Comment:
Are the OracleUpper, OracleUpperTable, and OracleUpperTableGenratorTest
actually used within Phoenix? I just see references to LocaleUtils and
LinguisticSort in Phoenix, and I don't see a reference to the three Oracle*
classes from either of those. Did I miss a dependency?
> Remove dependency on the i18n-util library
> ------------------------------------------
>
> Key: PHOENIX-6818
> URL: https://issues.apache.org/jira/browse/PHOENIX-6818
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Assignee: Mate Szalay-Beko
> Priority: Major
>
> i18n-util development seems to have stopped.
> We should copy the few relevant classes that we use from it, and maintain
> them in Phoenix.
> This also means that we need to depend explicitly on the icu4j library that
> i18n-util depends on.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
