[
https://issues.apache.org/jira/browse/PHOENIX-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635442#comment-17635442
]
ASF GitHub Bot commented on PHOENIX-6818:
-----------------------------------------
symat commented on PR #1527:
URL: https://github.com/apache/phoenix/pull/1527#issuecomment-1318899148
@stoty , can you please take a look on these yetus checks? Maybe I missed
something... it is my first PR in Phoenix, as far as I remember :)
> error: @author — The patch appears to contain 8 @author tags which the
community....
This was indeed an issue in the original patch, but was fixed in my second
commit.
> checkstyle — root: The patch generated 2 new + 117 unchanged
Here I see two remaining checkstyle failures on SortablePicklistItem.java.
This class was part of my first commit, but later I realized that we don't need
it and I deleted this class. Yet it appears in the latest checkstyle report for
some reason.
> Remove dependency on the i18n-util library
> ------------------------------------------
>
> Key: PHOENIX-6818
> URL: https://issues.apache.org/jira/browse/PHOENIX-6818
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Assignee: Mate Szalay-Beko
> Priority: Major
>
> i18n-util development seems to have stopped.
> We should copy the few relevant classes that we use from it, and maintain
> them in Phoenix.
> This also means that we need to depend explicitly on the icu4j library that
> i18n-util depends on.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
