richardantal commented on code in PR #112:
URL:
https://github.com/apache/phoenix-queryserver/pull/112#discussion_r1039300053
##########
pom.xml:
##########
@@ -701,6 +702,13 @@
<name>!skip.code-coverage</name>
</property>
</activation>
+ <properties>
+ <sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
+
<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>
+ <sonar.coverage.jacoco.xmlReportPaths>
+ ${project.build.directory}/site/jacoco/jacoco.xml
Review Comment:
Why don't we have `phoenix-queryserver-assembly` here like for the phoenix
main repo?
##########
dev/code-coverage/run-coverage.sh:
##########
@@ -0,0 +1,70 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+usage() {
+ echo
+ echo "options:"
+ echo " -h Display help"
+ echo " -u SonarQube Host URL"
+ echo " -l SonarQube Login Credentials"
+ echo " -k SonarQube Project Key"
+ echo " -n SonarQube Project Name"
+ echo " -t Number of threads (example: 1 or 2C)."
+ echo
+ echo "Important:"
+ echo " The required parameters for publishing the coverage results to
SonarQube:"
+ echo " - Host URL"
+ echo " - Login Credentials"
+ echo " - Project Key"
+ echo
+}
+
+execute() {
+ SCRIPT_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
+ MAIN_POM="${SCRIPT_DIR}/../../pom.xml"
+ # Check the syntax for the THREAD_COUNT variable
+ if [[ "$THREAD_COUNT" =~ ^[0-9]+([.][0-9]+)?$ ]] || [[ "$THREAD_COUNT" =~
^[0-9]+([.][0-9]+)+[C]?$ ]]; then
+ THREADS="${THREAD_COUNT}"
+ else
+ THREADS=1
+ fi
+
+ mvn -B -e -f "$MAIN_POM" clean verify -Pcodecoverage -fn
-Dmaven.javadoc.skip=true -DskipShade -T "$THREADS"
Review Comment:
Shouldn't we have `coverage` profile here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
