[ 
https://issues.apache.org/jira/browse/PHOENIX-6836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643170#comment-17643170
 ] 

ASF GitHub Bot commented on PHOENIX-6836:
-----------------------------------------

richardantal commented on code in PR #112:
URL: 
https://github.com/apache/phoenix-queryserver/pull/112#discussion_r1039300053


##########
pom.xml:
##########
@@ -701,6 +702,13 @@
             <name>!skip.code-coverage</name>
         </property>
       </activation>
+      <properties>
+          <sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
+          
<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>
+          <sonar.coverage.jacoco.xmlReportPaths>
+              ${project.build.directory}/site/jacoco/jacoco.xml

Review Comment:
   Why don't we have `phoenix-queryserver-assembly` here like for the phoenix 
main repo?



##########
dev/code-coverage/run-coverage.sh:
##########
@@ -0,0 +1,70 @@
+#!/usr/bin/env bash
+#  Licensed under the Apache License, Version 2.0 (the "License");
+#  you may not use this file except in compliance with the License.
+#  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+usage() {
+  echo
+  echo "options:"
+  echo "  -h     Display help"
+  echo "  -u     SonarQube Host URL"
+  echo "  -l     SonarQube Login Credentials"
+  echo "  -k     SonarQube Project Key"
+  echo "  -n     SonarQube Project Name"
+  echo "  -t     Number of threads (example: 1 or 2C)."
+  echo
+  echo "Important:"
+  echo "  The required parameters for publishing the coverage results to 
SonarQube:"
+  echo "    - Host URL"
+  echo "    - Login Credentials"
+  echo "    - Project Key"
+  echo
+}
+
+execute() {
+  SCRIPT_DIR="$(cd 

> Enable code coverage reporting to SonarQube in Phoenix-Queryserver
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-6836
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6836
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: queryserver
>            Reporter: Dóra Horváth
>            Assignee: Dóra Horváth
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to