kadirozde commented on code in PR #1531:
URL: https://github.com/apache/phoenix/pull/1531#discussion_r1064298983


##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -815,6 +818,10 @@ private void 
getCurrentRowStates(ObserverContext<RegionCoprocessorEnvironment> c
                                      BatchMutateContext context) throws 
IOException {
         Set<KeyRange> keys = new HashSet<KeyRange>(context.rowsToLock.size());
         context.dataRowStates = new HashMap<ImmutableBytesPtr, Pair<Put, 
Put>>(context.rowsToLock.size());
+        if (context.hasUncoveredIndex && !context.hasGlobalIndex && 
!context.hasTransform

Review Comment:
   @tkhurana, You are right. I made the necessary change and included a test 
case for it. Currently, if a mutation in a mini batch is a partial update, the 
data table rows will read for all mutations in the batch. We can further 
optimize this in future by just reading rows only for partial mutations instead 
of all mutations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to